Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update the logic to build cache key for GraphQL input type #143

Merged
merged 17 commits into from
Apr 26, 2019
Merged

Update the logic to build cache key for GraphQL input type #143

merged 17 commits into from
Apr 26, 2019

Conversation

desokroshan
Copy link
Contributor

@desokroshan desokroshan commented Apr 3, 2019 •
edited
Loading

Issue #, if available:
Fixes #103
Description of changes:

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@desokroshan desokroshan changed the title Update the logic to build cache key for GraphQL input type[WIP] [WIP]Update the logic to build cache key for GraphQL input type Apr 3, 2019
@desokroshan desokroshan mentioned this pull request Apr 5, 2019
Closed
@desokroshan desokroshan force-pushed the input-type-cache-key branch from 6fb2720 to 15840b7 Compare April 11, 2019 00:11
@arok
Copy link

arok commented Apr 16, 2019

When you plan to roll out this fix?

minbi
minbi suggested changes Apr 25, 2019
View reviewed changes
aws-android-sdk-appsync-tests/gradle.properties Outdated Show resolved Hide resolved
aws-android-sdk-appsync-tests/gradle.properties Outdated Show resolved Hide resolved
...roidTest/java/com/amazonaws/mobileconnectors/appsync/AWSAppSyncQueryInstrumentationTest.java Outdated Show resolved Hide resolved
...sdk-appsync-tests/src/main/graphql/com/amazonaws/mobileconnectors/appsync/demo/posts.graphql Outdated Show resolved Hide resolved
build.gradle Outdated Show resolved Hide resolved
settings.gradle Show resolved Hide resolved
...roidTest/java/com/amazonaws/mobileconnectors/appsync/AWSAppSyncQueryInstrumentationTest.java Outdated Show resolved Hide resolved
...-runtime/src/main/java/com/apollographql/apollo/internal/json/SortedInputFieldMapWriter.java Show resolved Hide resolved
aws-android-sdk-appsync-api/src/main/java/com/apollographql/apollo/api/InputType.java Show resolved Hide resolved
@desokroshan desokroshan marked this pull request as ready for review April 25, 2019 19:58
@desokroshan desokroshan requested a review from minbi April 25, 2019 21:18
@desokroshan desokroshan changed the title [WIP]Update the logic to build cache key for GraphQL input type Update the logic to build cache key for GraphQL input type Apr 26, 2019
@minbi minbi merged commit 7c66510 into master Apr 26, 2019
@minbi minbi deleted the input-type-cache-key branch April 26, 2019 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@minbi minbi Awaiting requested review from minbi

Assignees

@desokroshan desokroshan

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

GraphQL Input types toString() as cache key instead of resolving input values
4 participants
@desokroshan @arok @minbi @frankmuellr